Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow configuring whether to auto close the drive's tray #505

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Allow configuring whether to auto close the drive's tray #505

merged 1 commit into from
Sep 23, 2020

Conversation

JoeLametta
Copy link
Collaborator

@JoeLametta JoeLametta commented Sep 17, 2020 •
edited
Loading

Untested.

@JoeLametta
Copy link
Collaborator Author

Tested: doesn't work.

self.options.drive_auto_close appears to be None probably because it's an option declared in whipper/command/main.py (not in whipper/command/cd.py where the check if located).

@JoeLametta JoeLametta changed the title Allow configuring whether to auto close the drive's tray WIP: Allow configuring whether to auto close the drive's tray Sep 19, 2020
@JoeLametta JoeLametta force-pushed the feature/issue-488-drive-auto-close branch from 06f1eec to 6f84ca2 Compare September 23, 2020 17:38
@JoeLametta
Allow configuring whether to auto close the drive's tray
8a1c0fa 
Fixes #488.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
@JoeLametta JoeLametta force-pushed the feature/issue-488-drive-auto-close branch from 6f84ca2 to 8a1c0fa Compare September 23, 2020 17:42
@JoeLametta
Copy link
Collaborator Author

Updated: should work now. It was wrong before because the if condition was missing an explicit check for True.

@JoeLametta JoeLametta changed the title WIP: Allow configuring whether to auto close the drive's tray Allow configuring whether to auto close the drive's tray Sep 23, 2020
@JoeLametta JoeLametta merged commit 84cc824 into develop Sep 23, 2020
@JoeLametta JoeLametta deleted the feature/issue-488-drive-auto-close branch September 23, 2020 17:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Freso Freso Awaiting requested review from Freso

@MerlijnWajer MerlijnWajer Awaiting requested review from MerlijnWajer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JoeLametta