[MS-316] Refactor get all recursively to use requestParams instead of limit #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-fisher
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
LGTM - @Kirill-Vorobyev - Please take note this is a breaking change.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Github Issue
MS-316
Testing
Please describe the tests that you ran to verify your changes. If possible please also provide steps to reproduce and screenshots of test evidence.
These tests should be live, not unit/integration tests.
Reviewer Checklist
Reviewer: please make sure that this has been filled out before approving
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.