-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Minor updates to BDBag/Deriva #519
Conversation
Codecov Report
@@ Coverage Diff @@
## master #519 +/- ##
==========================================
+ Coverage 92.15% 92.92% +0.77%
==========================================
Files 58 58
Lines 4460 4508 +48
==========================================
+ Hits 4110 4189 +79
+ Misses 350 319 -31
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes more sense to me and works as expected -- from the WT-centric view. I can see this changing in some way when we publish to DERIVA, particularly handling the metadata-CSV files.
c4c9cbb
to
74ac6fd
Compare
tale=False, | ||
) | ||
|
||
def getDatasetUID(self, doc: object, user: object) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly during export (our bags).
This PR adds following enhancement to BDBag and Deriva providers:
manifest-<alg>.txt
files are parsed and checksums are stored on imported girder objects (see eb2a284)manifest.json
is parsed to get additional metadata (see d8364fa). It's mostly stored raw on girder objects, with an exception of mimeType that's now properly set on imported items and their identifiers that are taken from bundledAs.uri section (see a1db594)TODO
How to test?
manifest-md5.txt
,fetch.txt
andmanifest.json
contain a lot of entries/remote files.NOTE: Bags are not necessarily complete, nor useful at this stage. Further enhancements will be surely needed.