Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove unused Globus scope to overcome ORCID 500 #552

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

craig-willis
Copy link

Fixes (for now) #534

Problem
ORCID limits the size of the state param to 2000 characters, otherwise returning 500. This happens on *.local now.

Approach
Removed the unused scope to reduce state param size

Test

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #552 (ae959d2) into master (7a88446) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #552   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files          60       60           
  Lines        4767     4768    +1     
=======================================
+ Hits         4425     4426    +1     
  Misses        342      342           
Impacted Files Coverage Δ
server/__init__.py 90.62% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Xarthisius Xarthisius merged commit 1bce771 into master Aug 31, 2022
@Xarthisius Xarthisius deleted the remove-unused-scope branch August 31, 2022 14:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants