Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: various small navbar fixes #101

Merged
merged 3 commits into from
Sep 18, 2020
Merged

fix: various small navbar fixes #101

merged 3 commits into from
Sep 18, 2020

Conversation

bodom0015
Copy link
Member

@bodom0015 bodom0015 commented Sep 1, 2020

Problem

The "Data Catalog" and "Compute Environment" links just contain static placeholder data.

Approach

Hide these links for now until these views are functional and add more value to the platform.

Fixes #97 - Hide the links until these views are finished

Other minor fixes on this branch:

  • Fixes Task viewer takes up button real estate #84 - Adjusted notification stream margins so it no longer overlaps with the navbar
  • Added missing User Guide link to the navbar (clicking icon previously did nothing)
  • Display avatar in the navbar when available, disabled menu item for avatar/username, as clicking it currently does nothing

How to Test

Prerequisites: none

  1. Checkout this branch locally, rebuild the dashboard
  2. Login to the WholeTale Dashboard
    • You should see only "Tale Dashboard" in the navbar
    • You should not see "Data Catalog" or "Compute Environments"
    • You should see your gravatar displayed in the navbar, if you have one set
  3. Expand the Notification Stream panel
    • You should see the placeholder text for the notification stream is slightly more centered
  4. Expand the user dropdown and hover over your name
    • Your cursor should not indicate that this item is clickable
  5. Click the (i) symbol in the navbar
    • You should be brought to the User Guide

@bodom0015 bodom0015 changed the title fix: hide placeholder navbar links fix: hide placeholder navbar links, fix notification stream margin, fix user guide link, slightly adjust avatar display Sep 1, 2020
@bodom0015 bodom0015 changed the title fix: hide placeholder navbar links, fix notification stream margin, fix user guide link, slightly adjust avatar display fix: various small navbar fixes Sep 1, 2020
@Xarthisius Xarthisius merged commit 61f9ff9 into master Sep 18, 2020
@Xarthisius Xarthisius deleted the hide-placeholder-navs branch September 18, 2020 15:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Catalog -> Add Data modal not opening Task viewer takes up button real estate
3 participants