Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add a width to first column to prevent whitespace on select-data-dialog #104

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

bodom0015
Copy link
Member

@bodom0015 bodom0015 commented Sep 2, 2020

Problem

Some HTTPS dataset subfolders appear to render with an excessive amount of space.

Fixes #90

Approach

While I still don't know what was causing this problem, adding a width to the first column prevents it from taking up too much space in these cases.

Appears to be related to whole-tale/girder_wholetale#304, but I have no idea how or why. This behavior seems to only manifest with these types of HTTPS resources.

How to Test

Prerequisites: at least one Tale created that you own, at least one HTTPS dataset resource registered

Example: Register https://raw.githubusercontent.com/whole-tale/dashboard/master/.travis.yml

Ideally: many different datasets registered

  1. Checkout this branch locally, rebuild the dashboard
  2. Login to the WholeTale Dashboard
  3. Navigate to the Tale Catalog and choose "My Tales"
  4. Scroll to a Tale that you own and click View
    • You should be brought to the Run > Metadata view
  5. Click the "Files" tab
    • You should be brought to the Run > Files view
  6. On the left side, click "External Data"
    • You should see the right side file browser change to show attached datasets
  7. Click the (+) button at the top-right and choose "WT Data Catalog"
    • You should see the select-data modal appear
  8. On the left side of the modal, click on "WT Catalog"
    • You should see the right side of the modal change to show the full data catalog
  9. From the list, double-click an HTTPS resource (these usually appear as URLs)
    • You should see the name of the dataset you just clicked now appears in blue at the top
    • You should see the contents of this folder are now shown
    • You should see that the first column (with the folder icon) does not take up an unreasonable amount of space

@bodom0015 bodom0015 changed the title fix: add a width to first column to cut down on excessive spacing fix: add a width to first column to prevent whitespace on select-data-dialog Sep 2, 2020
@ThomasThelen ThomasThelen merged commit e6b24b4 into master Sep 21, 2020
@ThomasThelen ThomasThelen deleted the fix-excessive-spacing-on-select-data branch September 21, 2020 19:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excessive spacing in the select-data modal's tree hierarchy
3 participants