Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TypeError when calling genbank_get_genomes_by_taxon.py #97

Closed
jvollme opened this issue Oct 24, 2017 · 2 comments
Closed

TypeError when calling genbank_get_genomes_by_taxon.py #97

jvollme opened this issue Oct 24, 2017 · 2 comments
Assignees
Labels
bug something isn't working how it should

Comments

@jvollme
Copy link

jvollme commented Oct 24, 2017

Summary:

When calling genbank_get_genomes_by_taxon.py with the --retries argument, I get a TypeError, because the argument is stored as a string, but evaluated as an integer.

I guess could be most easily fixed if all Integer arguments (--retries, --batchsize and --timeout) would be explicitely set as "type = int" during the respective argparse parser.add_argument() calls.

@widdowquinn widdowquinn self-assigned this Oct 25, 2017
@widdowquinn widdowquinn added the bug something isn't working how it should label Oct 25, 2017
@widdowquinn
Copy link
Owner

You're correct. That's a hole in my testing (script inputs) that I've now got some cover for in the new version. Thank you for spotting it - I'll get it sorted and push out a new version.

widdowquinn added a commit that referenced this issue Oct 25, 2017
GenBank download script now insists on integer input for
--batchsize, --retries, and --timeout
widdowquinn added a commit that referenced this issue Oct 25, 2017
fix issue #97 (wrong script input types)
@widdowquinn
Copy link
Owner

This issue should be fixed with commit 69503d3, and I've pushed a new version (v0.2.7) to PyPI and Docker so you should be able to get those with a pip install or docker run.

This should fix the issue, but please do raise another if you find any other problems.

L.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug something isn't working how it should
Projects
None yet
Development

No branches or pull requests

2 participants