Cope with missing labels #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. Using output from genbank_get_genomes_by_taxon.py which writes classes.txt and labels.txt but adding one or two local FASTA files without updating the caption files. Avoids getting a nasty KeyError (although perhaps a warning would be better?)
widdowquinn
added
the
enhancement
|
Thanks @peterjc - that's been merged in to v0.2. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Pull request is against the v0.2 development branch, it would need tweaking to apply to the current master branch.
Use case: Have output from
genbank_get_genomes_by_taxon.pywhich writesclasses.txtandlabels.txtbut added one or two local FASTA files without updating the caption files.This commit avoids getting a nasty KeyError (although perhaps a warning would be better?)