Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WIP: point z-axis up, change some settings for OrbitControls #272

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mgeier
Copy link
Contributor

@mgeier mgeier commented Sep 23, 2019

I really like this project, but one thing I always found irritating was the behavior of the mouse controls for rotation.

There have been some discussions before, e.g.:

I've tried to hopefully improve on that, but I guess some of it might not be the right way to do it. I'm hoping for plentiful feedback!

These are the changes I intended:

  • point the z-axis up
  • enable panning (in OrbitControls), and select the "good" panning mode

I might have done some unintended changes and it's quite likely that I've completely broken something.

I'm mostly interested in the "orbit" controls, I don't see why anyone would want the "trackball" controls (now that the "orbit" controls work much better).

I'm not sure what the initial camera position should be ...

@mgeier
Copy link
Contributor Author

mgeier commented Sep 24, 2019

I've been mixing a few things here, I've made a separate PR that isolates the "enable panning" feature: #273.

@maartenbreddels maartenbreddels force-pushed the master branch 2 times, most recently from e861e87 to 6dead3f Compare April 13, 2021 12:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant