docs update code markdown_editor #893
Open
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iisakkirotko
requested changes
Dec 6, 2024
solara/website/pages/documentation/components/output/markdown_editor.py
Outdated
Show resolved
Hide resolved
maartenbreddels
force-pushed
the
master
branch
2 times, most recently
from
cded5b2 to
32af76f
Compare
iisakkirotko
approved these changes
Dec 30, 2024
iisakkirotko
requested changes
Jan 6, 2025
| @@ -36,12 +35,12 @@ def Page(): | |||
| """.strip() | |||
|
|
|||
| markdown_text, set_markdown_text = solara.use_state(markdown_initial) | |||
| with solara.HBox(grow=True) as main: | |||
| with solara.VBox(): | |||
| with solara.Row(grow=True) as main: | |||
There was a problem hiding this comment.
Row doesn't accept grow as an argument.
Suggested change
| with solara.Row(grow=True) as main: | |
| with solara.Row() as main: |
| @@ -36,12 +35,12 @@ def Page(): | |||
| """.strip() | |||
|
|
|||
| markdown_text, set_markdown_text = solara.use_state(markdown_initial) | |||
| with solara.HBox(grow=True) as main: | |||
| with solara.VBox(): | |||
| with solara.Row(grow=True) as main: | |||
There was a problem hiding this comment.
Also, I missed this last time, but the return main pattern can also be removed here.
Suggested change
| with solara.Row(grow=True) as main: | |
| with solara.Row(grow=True): |
| @@ -36,12 +35,12 @@ def Page(): | |||
| """.strip() | |||
|
|
|||
| markdown_text, set_markdown_text = solara.use_state(markdown_initial) | |||
There was a problem hiding this comment.
And I also now noticed that the use_state here can be replaced with use_reactive, and .value and .set can be used throughout.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.