Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add legend #62

Merged
merged 4 commits into from Jun 15, 2022
Merged

add legend #62

merged 4 commits into from Jun 15, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 14, 2022

add legend using HTML template (#1)

tracevis-legend

@xhdix xhdix self-requested a review June 14, 2022 10:25
@xhdix xhdix linked an issue Jun 14, 2022 that may be closed by this pull request
@xhdix
Copy link
Contributor

xhdix commented Jun 14, 2022

Thanks for the PR. ❤️ 🌺
Is it possible to have them a bit smaller?
I'm not sure if I did it correctly but:

23,24c23,24
<       width: 270px;
<       height: 360px;
---
>       width: 135px;
>       height: 180px;
228,230c228,230
<       let x = -legend.clientWidth / 2 + 65;
<       let y = -legend.clientHeight / 2 + 30;
<       let step = 70;
---
>       let x = -legend.clientWidth / 2 + 35;
>       let y = -legend.clientHeight / 2 + 15;
>       let step = 35;
236c236
<               x: idx < max_row ? x : x + 125,
---
>               x: idx < max_row ? x : x + 62,
240,241c240,241
<               size: 10,
<               font: '14px arial black',
---
>               size: 5,
>               font: '7px arial black',

image

@xhdix xhdix requested a review from RYNEQ June 14, 2022 18:06
Copy link
Contributor

@xhdix xhdix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for now.. I'm going to merge it. Thank you @r3xcr4py! ❤️ 🌺

@RYNEQ I will create a new issue for follow-up works and ideas.

@xhdix xhdix merged commit c4384ac into wikicensorship:main Jun 15, 2022
@ghost ghost deleted the add-legend branch June 15, 2022 10:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request priority/low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add legend
2 participants