Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: make it easier to use packet input #63

Merged
merged 1 commit into from
Jun 15, 2022
Merged

feat: make it easier to use packet input #63

merged 1 commit into from
Jun 15, 2022

Conversation

xhdix
Copy link
Contributor

@xhdix xhdix commented Jun 14, 2022

now users can paste from Ether layer if there is no layer before IP layer. (e.g, "Linux cooked capture")

@xhdix xhdix requested a review from RYNEQ June 14, 2022 15:10
@xhdix xhdix added enhancement New feature or request priority/medium labels Jun 14, 2022
@xhdix xhdix requested a review from bassosimone June 15, 2022 10:30
bassosimone
bassosimone approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

(works on macOS and simplifies importing packets 🥳 )

@xhdix xhdix merged commit ac97ba1 into main Jun 15, 2022
@xhdix xhdix deleted the feature/easier_packet_input branch June 15, 2022 16:48
@xhdix xhdix mentioned this pull request Jun 19, 2022
Closed
@xhdix xhdix linked an issue Jun 19, 2022 that may be closed by this pull request
Improvement: handle hexdump in a better way. #45
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

@RYNEQ RYNEQ Awaiting requested review from RYNEQ

Assignees
No one assigned
Labels
enhancement New feature or request priority/medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvement: handle hexdump in a better way.
2 participants
@xhdix @bassosimone