Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: iptables existence #70

Merged
merged 5 commits into from
Jun 27, 2022
Merged

fix: iptables existence #70

merged 5 commits into from
Jun 27, 2022

Conversation

RYNEQ
Copy link
Collaborator

@RYNEQ RYNEQ commented Jun 27, 2022

There was a a problem on exception handling for iptables existence check routine which is fixed
Also using iptables has been made optional as some systems may have other type of firewall
Now only if user ask for auto config of iptables and it doesn't exist app crashes with error, otherwise it assumes user has no problem about auto RST response of linux

RYNEQ added 2 commits June 27, 2022 19:31
iptables existence check fixed
and using it is optional
@xhdix xhdix self-requested a review June 27, 2022 15:27
@xhdix xhdix added bug Something isn't working priority/high labels Jun 27, 2022
RYNEQ added 3 commits June 27, 2022 20:29
add exception handling for rexmit
raise more decriptive error message if iptables is not installed
fix typo in iptables existence error
Copy link
Contributor

@xhdix xhdix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️ 🌺
LGTM! 🎉

@xhdix xhdix merged commit 7e1fdf3 into main Jun 27, 2022
@xhdix xhdix deleted the fix/iptables-existance branch June 27, 2022 18:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working priority/high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants