[WFTC-54] forbid to enlist XAResource to a timeouted transaction #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlloyd
requested changes
Jan 2, 2019
| @@ -160,7 +158,8 @@ public int getTransactionTimeout() { | |||
|
|
|||
| public boolean enlistResource(final XAResource xaRes) throws RollbackException, IllegalStateException, SystemException { | |||
| Assert.checkNotNullParam("xaRes", xaRes); | |||
| final int estimatedRemainingTime = max(1, getEstimatedRemainingTime()); | |||
| final int estimatedRemainingTime = getEstimatedRemainingTime(); | |||
| if(estimatedRemainingTime == 0) throw Log.log.cannotEnlistToTimeoutedTransaction(xaRes, this); | |||
ochaloup
force-pushed
the
WFTC-54-timeouted-txn-throws-exception
branch
from
42c0435 to
0712f8c
Compare
dmlloyd
approved these changes
Jan 2, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/WFTC-54
if
XAResourceis to be enlisted to a transaction that already timeouted then rather throw an exception than continue with the enlistment (see https://issues.jboss.org/browse/WFTC-54?focusedCommentId=13677791#comment-13677791)This changes the behaviour as the previously the enlistment was permitted and the timeout was changed to value
1second despite the transaction already timed out.