[WFTC-61] the connection failures are intermittent and should be thrown as RMFAIL #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochaloup
force-pushed
the
WFTC-61-xaer-rmfail-for-io-exceptions
branch
from
1634ce8 to
6f97244
Compare
…be used RMFAIL announces to transaction manager that the work could be retried
ochaloup
force-pushed
the
WFTC-61-xaer-rmfail-for-io-exceptions
branch
from
6f97244 to
e1448a4
Compare
tadamski
approved these changes
Apr 8, 2019
fl4via
approved these changes
Apr 16, 2019
|
@dmlloyd yes, this is okay to merge |
This was referenced Apr 18, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and should be announced as such to transaction manager
https://issues.jboss.org/browse/WFTC-61
https://issues.jboss.org/browse/WFLY-11937
@fl4via @tadamski this fix changes the error codes from
XAER_RMERRtoXAER_RMFAILwhenIOExceptionis received from the remote call. The failed remote call means that the action could be repeated to find out the outcome of the transaction. TheRMERRdefines an un-recoverable error and in such case the transaction is moved to heuristic and operator needs to do manual change.I did the change not only for the
BlockingInvocation.Response response = invocation.getResponse()but for the code at// write rollback-only request. I think it's correct to be changed there as well but if you can @fl4via take a look to confirm I would be grateful.