This repository has been archived by the owner on Jan 31, 2022. It is now read-only.
Correctly normalize parameters for oAuth authentication #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently oAuth authenfication for nested arrays is broken as those information is not decoded like the clients encode the information. Nested array handling is not covered at all. This patch simplifies the normalization handling and processes nested arrays in a proper way. Unfortunately oAuth documentation fails to give some expectations on how to normalize nested array information correctly, so each dimension is sorted on its own.
|
Fixes: #31 |
IchHabRecht
force-pushed
the
willdurand
branch
from
68919df to
d38a7a9
Compare
Numeric arrays have 0 as key that is transferred as parent key and should be taken into account correctly.
IchHabRecht
force-pushed
the
willdurand
branch
from
39a23f5 to
8bf6622
Compare
Normalization should not care about empty values.
IchHabRecht
force-pushed
the
willdurand
branch
from
8bf6622 to
9571d8c
Compare
We need to make sure that numeric arrays are replaced instead of being merged.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently oAuth authenfication for nested arrays is broken as those
information is not decoded like the clients encode the information.
Nested array handling is not covered at all.
This patch simplifies the normalization handling and processes
nested arrays in a proper way. Unfortunately oAuth documentation
fails to give some expectations on how to normalize nested array
information correctly, so each dimension is sorted on its own.