Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add px to positional css values for ios devices #228

Merged
merged 1 commit into from
Aug 14, 2021

Conversation

mindnektar
Copy link

Fixes #182

@lincolnthree
Copy link

That would do it. Lol :) Nice catch.

@BwamNL
Copy link

BwamNL commented Aug 4, 2021

Agree!

@efimweb
Copy link

efimweb commented Aug 11, 2021

@willmcpo could you approve it please?

Copy link

@c4ndybar c4ndybar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merge it!

@willmcpo willmcpo merged commit 79c4cf2 into willmcpo:master Aug 14, 2021
@efimweb
Copy link

efimweb commented Aug 20, 2021

@willmcpo could you publish it to npm?

@sdennett55
Copy link

@willmcpo i'll give you $10 if you publish this to npm.

@lincolnthree
Copy link

lincolnthree commented Mar 28, 2022

This PR still has another bug:

line 130

Same problem, needs + 'px' added as a suffix.

@owenhoskins
Copy link

This fixed my #182 for me. Would be handy to have this on NPM. Currently using it via "body-scroll-lock": "https://github.com/willmcpo/body-scroll-lock#79c4cf2c956eb7d5cf8d54a03d12751bc6ac8aa3" in my package.json

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disableBodyScroll: content scrolls back to top
8 participants