Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Set minimum railties version to match used methods #19

Merged
merged 1 commit into from
Apr 12, 2023
+3 −3
Merged

Set minimum railties version to match used methods #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions committee-rails.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ['lib']
spec.add_dependency 'committee', '>= 5.0.0'
spec.add_dependency 'activesupport'
spec.add_dependency 'actionpack'
spec.add_dependency 'railties'
spec.add_dependency 'activesupport', '>= 5.1'
spec.add_dependency 'actionpack', '>= 5.1'
spec.add_dependency 'railties', '>= 5.1'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would be more helpful to specify the version in actionpack and activesupport as well as in the railties.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the PR 👍

end