Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix some deprecation warning #34

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

ydah
Copy link
Contributor

@ydah ydah commented Jan 23, 2024

  • Fix a deprecation warning for config.active_support.cache_format_version = 6.1: 1c8b4db
  • Fix a deprecation warning for action_dispatch.show_exceptions to true: 1cff29c
  • Fix a deprecation warning for strict_reference_validation: 453fe3d
❯ bundle exec rake
/ydah/.rbenv/versions/3.1.2/bin/ruby -I/ydah/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rspec-core-3.12.2/lib:/ydah/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rspec-support-3.12.1/lib /ydah/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rspec-core-3.12.2/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb
DEPRECATION WARNING: Support for `config.active_support.cache_format_version = 6.1` has been deprecated and will be removed in Rails 7.2.

Check the Rails upgrade guide at https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#new-activesupport-cache-serialization-format
for more information on how to upgrade.
 (called from <top (required)> at /ydah/committee-rails/spec/fake_app/rails_app.rb:7)
.....DEPRECATION WARNING: Setting action_dispatch.show_exceptions to true is deprecated. Set to :all instead. (called from block (4 levels) in <top (required)> at /ydah/committee-rails/spec/lib/methods_spec.rb:70)
DEPRECATION WARNING: Setting action_dispatch.show_exceptions to true is deprecated. Set to :all instead. (called from block (4 levels) in <top (required)> at /ydah/committee-rails/spec/lib/methods_spec.rb:70)
..[DEPRECATION] openapi_parser will default to strict reference validation from next version. Pass config `strict_reference_validation: true` (or false, if you must) to quiet this warning.
.

Finished in 0.08263 seconds (files took 1.63 seconds to load)
8 examples, 0 failures

Copy link
Owner

@willnet willnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge it in when you fix the conflict.

ydah added 3 commits February 6, 2024 00:21
…sion = 6.1`

```
DEPRECATION WARNING: Support for `config.active_support.cache_format_version = 6.1` has been deprecated and will be removed in Rails 7.2.
```
```
DEPRECATION WARNING: Setting action_dispatch.show_exceptions to true is deprecated. Set to :all instead. (called from block (4 levels) in <top (required)> at /ydah/committee-rails/spec/lib/methods_spec.rb:70)
```
```
[DEPRECATION] openapi_parser will default to strict reference validation from next version. Pass config `strict_reference_validation: true` (or false, if you must) to quiet this warning.
```
@ydah ydah force-pushed the fix-deprecation-warning-in-test branch from 453fe3d to e58e964 Compare February 5, 2024 15:23
@ydah
Copy link
Contributor Author

ydah commented Feb 5, 2024

Sorry for the delay. Conflicts have been resolved.

@willnet willnet merged commit 3dbfbde into willnet:main Feb 9, 2024
7 checks passed
@ydah ydah deleted the fix-deprecation-warning-in-test branch February 9, 2024 01:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants