Add better rotation support. Fixes bug where the plugin container would become the wrong size on rotation. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMacHumphries
approved these changes
Dec 2, 2017
| @@ -97,4 +97,14 @@ -(void)deactivateSnapshotPluginView | |||
| [_pluginMenuItem setSelected:NO animated:YES]; | |||
| } | |||
|
|
|||
| -(void)snapshotPluginViewWillTransitionToSize:(CGSize)size withTransitionCoordinator:(id<UIViewControllerTransitionCoordinator>)coordinator | |||
There was a problem hiding this comment.
Should these be optional, maybe?
|
@iMacHumphries I updated the naming there, to make it a little more obvious what is going on. |
|
LGTM |
Add circle configuation.
…ld become the wrong size on rotation.
chrsmys
force-pushed
the
bugfix/betterRotationSupport
branch
from
eea8888
to
51b4275
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.