-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Added NODE_ENV to configure debug mode #80
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,7 +64,7 @@ return /******/ (function(modules) { // webpackBootstrap | |
* | ||
* @return {Function} | ||
*/ | ||
var debug = 0 ? console.log.bind(console, '[fastdom-strict]') : function() {}; | ||
var debug = false ? console.log.bind(console, '[fastdom-strict]') : function() {}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this different to the change in |
||
|
||
/** | ||
* Enabled state | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,7 @@ | |
* | ||
* @return {Function} | ||
*/ | ||
var debug = 0 ? console.log.bind(console, '[fastdom]') : function() {}; | ||
var debug = process.env.NODE_ENV !== 'production' ? console.log.bind(console, '[fastdom]') : function() {}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is going to throw if users aren't using webpack/browserify. |
||
|
||
/** | ||
* Normalized rAF | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
// global variables for karma | ||
window.process = { env: { NODE_ENV: 'production'} }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to throw if users aren't using webpack/browserify