Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix tonelib-noisereducer (VERSION_PUBLISHED blank) #1012

Merged
merged 5 commits into from
Feb 18, 2024

Conversation

rasa
Copy link
Contributor

@rasa rasa commented Feb 16, 2024

The URL no longer has the version number in it. See
https://www.tonelib.net/downloads.html

Copy link
Member

@philclifford philclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite right - gives the first version from the cache file instead of the correct version for the particular app.

@rasa
Copy link
Contributor Author

rasa commented Feb 17, 2024

@philclifford It should be OK now. Thx for the feedback.

@philclifford
Copy link
Member

Alas you still need to compare with my PR - the version installed by the deb is 1.2-0 , which is "less than" the announced version and causes endless bogus "updates", hence the sed fix.
Without something like that you end up with

  [+] tonelib-noisereducer (1.2-0) has an update pending. 1.2.0 is available.

@philclifford philclifford merged commit 8acd96e into wimpysworld:main Feb 18, 2024
1 check passed
@rasa rasa deleted the fix-tonelib-noisereducer branch February 19, 2024 19:42
hsbasu pushed a commit to mamolinux/deb-get that referenced this pull request Nov 6, 2024
* Fix tonelib-noisereducer (VERSION_PUBLISHED blank)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants