Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Optimisation of apt update #434

Closed
wants to merge 0 commits into from
Closed

Optimisation of apt update #434

wants to merge 0 commits into from

Conversation

Flashwalker
Copy link
Contributor

Added two functions: update_repo and update_ppa to optimize apt update

@philclifford
Copy link
Member

This fixes #428

Copy link
Contributor Author

@Flashwalker Flashwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor

@natanjunges natanjunges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase with main.

@Flashwalker
Copy link
Contributor Author

Flashwalker commented Sep 26, 2022

Please rebase with main.

rebase and push?
or you are meen you merged it and now i can pull it from your main branch?
or what? Sorry, my git pr skills leave a lot to be desired

@natanjunges
Copy link
Contributor

If you go to your branch page in GitHub, you will see it is "3 commits ahead, 10 commits behind" the main branch (or something similar). It needs to get caught up with the main branch (the 10 commits it is behind), so the permission error the test workflow is complaining about gets fixed. If there are no merging conflicts, it should be pretty simple, just click on "Sync fork", and then on the green button that appears. If a red button appears instead, do not click on it, as it would wipe out all of your contributions. In this case, the merge conflicts would have to be resolved locally using the command line.

@Flashwalker
Copy link
Contributor Author

If you go to your branch page in GitHub, you will see it is "3 commits ahead, 10 commits behind"...

Ok, done.
Now it's just: "4 commits ahead"

deb-get Outdated Show resolved Hide resolved
Copy link
Contributor

@natanjunges natanjunges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase with main. As there is already a function named update_repo, rename yours (something like update_apt_repo).

@Flashwalker
Copy link
Contributor Author

Github suggested me to discard 4 commits. Not sure it was right, but done

@natanjunges
Copy link
Contributor

You should not have discarded them, as they were your contributions. Please recommit them and reopen this PR.

@Fuseteam
Copy link
Contributor

Fuseteam commented Nov 5, 2022

oh dear, i'm not sure if they know how to do that

@Flashwalker
Copy link
Contributor Author

oh dear, i'm not sure if they know how to do that

I'd better make a new PR

@Flashwalker Flashwalker deleted the pullrequset branch November 11, 2022 08:13
@Flashwalker
Copy link
Contributor Author

new PR: #657

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants