-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Optimisation of apt update #434
Conversation
This fixes #428 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase with main.
rebase and push? |
If you go to your branch page in GitHub, you will see it is "3 commits ahead, 10 commits behind" the main branch (or something similar). It needs to get caught up with the main branch (the 10 commits it is behind), so the permission error the test workflow is complaining about gets fixed. If there are no merging conflicts, it should be pretty simple, just click on "Sync fork", and then on the green button that appears. If a red button appears instead, do not click on it, as it would wipe out all of your contributions. In this case, the merge conflicts would have to be resolved locally using the command line. |
Ok, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase with main. As there is already a function named update_repo
, rename yours (something like update_apt_repo
).
Github suggested me to discard 4 commits. Not sure it was right, but done |
You should not have discarded them, as they were your contributions. Please recommit them and reopen this PR. |
oh dear, i'm not sure if they know how to do that |
I'd better make a new PR |
new PR: #657 |
Added two functions: update_repo and update_ppa to optimize apt update