Don't bail on unsupported arch #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds check for ARCHS_SUPPORTED before bailing validate_deb when arch is unavailable/not supported.
I think this gets superseded by #774 does it not? |
|
I think both are needed. I'll take a look later. |
|
This may not be needed now, but IMHO it is better still to be put in place for any unforseen route to calling validate_deb() against an "unsupported app on this platform", or any future behaviour that gets there. I've pulled your commit into my PR branch and hopefully the |
This was referenced Apr 25, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds check for ARCHS_SUPPORTED before bailing validate_deb when arch is unavailable/not supported.
#752