Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

manifest: forgot to add jc #935

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Conversation

mralusw
Copy link
Contributor

@mralusw mralusw commented Nov 10, 2023

Didn't quite realize manifest has to be updated too...

@philclifford
Copy link
Member

No worries. I added it while correcting the docs so this may be superfluous. If I make it home in time I can merge this and revise my PR if needed.

@philclifford
Copy link
Member

Actually I can't merge it because a test status is required but the test doesn't run on changes only to manifest. That needs fixing. Meantime either @flexiondotorg needs to override the requirement or you might be able to provoke a test run by amending the commit to include a change in packages/jc (e.g. adding a comment or two from your excellent explanation of the string variable manipulations to help any future contributors improving their bash to read )

@mralusw
Copy link
Contributor Author

mralusw commented Nov 11, 2023

I've copied the anchoring to the rightmost dquote from #934 (has that PR been missed, BTW?)

@philclifford philclifford merged commit ebf0301 into wimpysworld:main Nov 11, 2023
2 checks passed
@mralusw mralusw deleted the add-apps-jc branch November 11, 2023 13:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants