Adds WebSocket protocal to localhost (#1007)

windup · Jul 12, 2023 · b2bd1b3 · b2bd1b3
1 parent b125554
commit b2bd1b3
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 2 deletions.
diff --git a/rules/rules-reviewed/cloud-readiness/localhost.windup.xml b/rules/rules-reviewed/cloud-readiness/localhost.windup.xml
@@ -31,7 +31,7 @@
                 <matches pattern="http(s)?://((localhost)|(127\.0\.0\.1))+(:[0-9]+)?(/.*)?" />
             </where>
         </rule>
-        <rule id="localhost-http-00001">
+        <rule id="localhost-jdbc-00002">
             <when>
                 <filecontent filename="{*}.{extensions}" pattern="{pattern}" />
             </when>
@@ -48,5 +48,22 @@
                 <matches pattern="jdbc:([a-z0-9-]+)://(localhost|127\.0\.0\.1)(:[0-9]+)?" />
             </where>
         </rule>
+        <rule id="localhost-ws-00003">
+            <when>
+                <filecontent filename="{*}.{extensions}" pattern="{pattern}" />
+            </when>
+            <perform>
+                <hint title="Local WebSocket Calls" effort="7" category-id="mandatory">
+                    <message>The app is trying to access local resource using WebSocket, please try to migrate the resource to cloud</message>
+                    <tag>localhost</tag>
+                </hint>
+            </perform>
+            <where param="extensions">
+                <matches pattern="(java|properties|jsp|jspf|tag|xml|txt|yaml)" />
+            </where>
+            <where param="pattern">
+                <matches pattern="ws(s)?://((localhost)|(127\.0\.0\.1))+(:[0-9]+)?(/.*)?" />
+            </where>
+        </rule>
     </rules>
 </ruleset>
diff --git a/rules/rules-reviewed/cloud-readiness/tests/data/localhost.properties b/rules/rules-reviewed/cloud-readiness/tests/data/localhost.properties
@@ -1,4 +1,6 @@
 mysql=jdbc:sqlserver://127.0.0.1:3306/asdf
 sqlserver=jdbc:sqlserver://localhost;encrypt=true;user=MyUserName;password=*****
 http=http://localhost:8080
-https=https://127.0.0.1:8080/ddd
+https=https://127.0.0.1:8080/ddd
+websocket=ws://localhost:8080
+websocketsecure=wss://127.0.0.1:8080/ddd
diff --git a/rules/rules-reviewed/cloud-readiness/tests/localhost.windup.test.xml b/rules/rules-reviewed/cloud-readiness/tests/localhost.windup.test.xml
@@ -29,6 +29,18 @@
                     <fail message="localhost jdbc usage was not found" />
                 </perform>
             </rule>
+            <rule id="localhost-ws-test-00003">
+                <when>
+                    <not>
+                        <iterable-filter size="2">
+                            <hint-exists message="The app is trying to access local resource using WebSocket" />
+                        </iterable-filter>
+                    </not>
+                </when>
+                <perform>
+                    <fail message="localhost websocket usage was not found" />
+                </perform>
+            </rule>
         </rules>
     </ruleset>
 </ruletest>