-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adds a rule about CORBA #1008
Adds a rule about CORBA #1008
Conversation
Hi @agoncal the tests are failing on this PR because the test class triggers rule You could maybe refactor your test and data to a subfolder so they don't trigger the other rules. |
I've moved the CORBA data to a |
@m-brophy one test is failing but I'm not sure what it is. In the trace there is |
@agoncal I kicked the test off again and it's passed now. Sometimes the build servers struggle a bit in USA work hours and things timeout etc. |
Cool ! So it can be merged ;o) |
The subfolder thing only works if all the rulesets in a folder have their test and data in a corresponding subfolder so each test only acts upon it's own data files- sorry, should have been clearer. In this case you would have had to do the same to local-storage too and that probably would have been enough |
I'll just link the PR to a JIRA and then merge it |
No description provided.