Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds a rule about CORBA #1008

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Adds a rule about CORBA #1008

merged 3 commits into from
Jul 13, 2023

Conversation

agoncal
Copy link
Contributor

@agoncal agoncal commented Jul 12, 2023

No description provided.

@m-brophy
Copy link
Contributor

Hi @agoncal the tests are failing on this PR because the test class triggers rule local-storage-00001 in ruleset local-storage.windup.xml and test local-storage-test-00001 then fails,presumably because it's looking for the rule to fire51 timesand it's getting 52.

You could maybe refactor your test and data to a subfolder so they don't trigger the other rules.

@agoncal
Copy link
Contributor Author

agoncal commented Jul 12, 2023

I've moved the CORBA data to a corba subfolder. Unfortunatelly local-storage looks into subfolders too. So I got rid of File access in the CORBA sample.

@agoncal
Copy link
Contributor Author

agoncal commented Jul 12, 2023

@m-brophy one test is failing but I'm not sure what it is. In the trace there is Could not find artifact org.jboss.windup.config:windup-config-impl:jar:6.3.0-SNAPSHOT in central

@m-brophy
Copy link
Contributor

m-brophy commented Jul 13, 2023

@agoncal I kicked the test off again and it's passed now. Sometimes the build servers struggle a bit in USA work hours and things timeout etc.

@agoncal
Copy link
Contributor Author

agoncal commented Jul 13, 2023

Cool ! So it can be merged ;o)

@m-brophy
Copy link
Contributor

I've moved the CORBA data to a corba subfolder. Unfortunatelly local-storage looks into subfolders too. So I got rid of File access in the CORBA sample.

The subfolder thing only works if all the rulesets in a folder have their test and data in a corresponding subfolder so each test only acts upon it's own data files- sorry, should have been clearer. In this case you would have had to do the same to local-storage too and that probably would have been enough

@m-brophy
Copy link
Contributor

I'll just link the PR to a JIRA and then merge it

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants