Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

add port config discovery in azure #964

Merged
merged 2 commits into from
May 23, 2023
Merged

add port config discovery in azure #964

merged 2 commits into from
May 23, 2023

Conversation

KaiqianYang
Copy link
Contributor

No description provided.

@PhilipCattanach
Copy link
Contributor

https://issues.redhat.com/browse/WINDUPRULE-1000

@PhilipCattanach
Copy link
Contributor

PhilipCattanach commented May 22, 2023 •
edited
Loading

Hi @KaiqianYang
The rules work perfectly fine.
The only minor change that I would request is that the list of file types also has yml currently it only has
(properties|yaml)

@KaiqianYang
Copy link
Contributor Author

KaiqianYang commented May 23, 2023 •
edited
Loading

Hi @KaiqianYang The rules work perfectly fine. The only minor change that I would request is that the list of file types also has yml currently it only has (properties|yaml)

@PhilipCattanach Thanks for the reminder. I have updated it to (properties|yaml|yml).

@PhilipCattanach
Copy link
Contributor

Reviewed and tested successfully.

@PhilipCattanach PhilipCattanach merged commit 7dc4670 into windup:master May 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaiqianYang @PhilipCattanach