Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump bindgen version to allow cross-compiling. #3

Closed
wants to merge 1 commit into from

Conversation

nsabovic
Copy link

The version of bindgen in Cargo.toml is reaaly old, and doesn't support cross-compilation.

This just bumps the dependency version.

Alternatively, something like >= 0.55.1,<1.0.0 might allow old versions to work also. I haven't seen any breakage with bindgen versions and they rev minor versions when they really should be reving patch because they're pre-1.0.

@nsabovic
Copy link
Author

nsabovic commented Nov 8, 2023

Thanks so much for landing this same change in bonjour-sys & reving the version! Is there anything I can do to help with this going through? This would allow us to go back to using zeroconf-rs from cargo so I'm motivated to help :)

@hgaiser
Copy link

hgaiser commented Jan 10, 2024

Any update on this @windy1 ? I'm also motivated to help, since I need this for zeroconf-rs.

@windy1
Copy link
Owner

windy1 commented Jan 13, 2024

Sorry I let this one slip! I am away this weekend and don't have access to a Linux box to verify right now, but I will update the bindgen version ASAP.

@hgaiser
Copy link

hgaiser commented Jan 15, 2024

Great, good to hear @windy1 ! It is also worth considering to remove the bindgen dependency on this crate altogether. I have done a similar thing here and opted to use a shell script instead.

@windy1
Copy link
Owner

windy1 commented Jan 21, 2024

Resolved by #5

@windy1 windy1 closed this Jan 21, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants