Plasma fixes #23
Merged
Plasma fixes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it more explicit.
This is a legacy import now.
This makes it look more integrated with other KDE apps.
The message bus for Plasma 6 has a different name.
Now plasmoid actions are defined in a declarative fashion in a QQmlListProperty over Plasmoid, and the old imperative JS api is deprecated. Similar to [1]. [1] https://invent.kde.org/plasma/kscreen/-/commit/8fd5e0c4
Better integrates with KDE look.
Instead of theme context property.
Adapt to API change.
There are already too many icons in the system tray, and most users are less likely to change the mode frequently once they select a mode, which makes the widget redundant to be always active.
Not needed anymore with Qt6.
After upstream change required.
The other version is not needed and produces a warning.
Simplifies the code.
The MainScript defaults to ui/main.qml and the version is unneeded because the plasmoid is part of the Plasma release cycle.
Improves integration.
Needed by API changes.
After some changes last year it's not used anymore.
Better style.
The IconThemes dependency is not used.
They are not used.
Fixes an oversight: people are going to upgrade from 5 to 6, some will have 3rd party plasmoids from the store that will still be for plasma5. We want a different error message when we know the plasmoid is "old" In Palsma4 times we used to have for the pure JavaScript plasmoids an api version key that could be used for things like that. This makes it a bit more future proof for any future api change there will be
Version Qt 6.6 and KF 6 respectively.
This needs to be the same as the one declared in the CMake file, otherwise Plasma crashes.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required fixes to run in a full Plasma 6 session.