Fix GLib scripts when Python path contains spaces #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyeaw
force-pushed
the
glib-fix-shebang
branch
from
898282f to
878aacd
Compare
|
@danyeaw not clear to me from the comments in the issue. Shall we wait to have an agreement or do you still want to ship this? |
|
Hi @nacho, I updated https://gitlab.gnome.org/GNOME/glib/-/issues/3331 with a new proposal based on a lot of feedback I received on my merge request. I would appreciate your feedback as well. Thanks! |
|
Hi @nacho, I think the right solution is for upstream to create a new meson option, however, it doesn't seem like we have consensus yet. Should we merge some type of fix in the meantime? |
|
Sure, go ahead |
|
@nacho, thanks, could you give the PR an approval please? |
nacho
approved these changes
Dec 16, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1436. The upstream issue is https://gitlab.gnome.org/GNOME/glib/-/issues/3331 and I opened https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4391 to resolve it.