Skip to content

Commit

Permalink
Fix protobuf dependency version
Browse files Browse the repository at this point in the history
Protobuf runtime version should always be newer than the protoc version
used. Setting a fixed protoc version in the github action, and setting
the required protobuf version to be at least the same as the protoc
version.

More info:
https://protobuf.dev/support/cross-version-runtime-guarantee/
  • Loading branch information
sgunes-wirepas committed Feb 3, 2025
1 parent aa36ed5 commit 7cfb589
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- name: Install Protoc
uses: arduino/setup-protoc@v3
with:
version: '29.x'
version: '29.3'
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Generate proto files
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@ def get_absolute_path(*args):
keywords=about["__keywords__"],
packages=find_packages(exclude=["contrib", "docs", "tests", "examples"]),
install_requires=[
"protobuf~=5.0"
"protobuf~=5.29.3"
]
)

0 comments on commit 7cfb589

Please # to comment.