Change command line options #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding an optional -b BRANCH argument to build_examples.py to enable comparing to and restoring from any branch or commit. That will help when e.g. reversing an unfortunate commit of generated files. This solves part 2 of issue wireviz#167.
When used to "git diff", it is easy to write "build_examples.py diff" instead of "build_examples.py compare" by a mistake. Therefore, "diff" is now an alias to "compare" so both commands will work. This solves part 3 of issue wireviz#167.
It seems, that the current implementation ignores --generate-bom, and that parser.add_argument() code line is therefore commented out until it gets implemented to avoid any confusion. This solves part 1 of issue wireviz#167.
Add -V command line option (and --version as an alias) to both wireviz.py and build_examples.py that show version number. Move the version number from setup.py into __init__.py to access the same version number specification from all files needing it. This solves part 4 of issue wireviz#167.
|
Great new features and nice implementation and commit structure :) Thanks! |
This was referenced Oct 14, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #167