forked from chen-anders/gh-ost
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add MySQL 8.4 Support #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oes not have 8.4.3
chen-anders
force-pushed
the
anders/mysql-8.4-support
branch
from
January 29, 2025 15:52
ffc60f3
to
7142b2b
Compare
michaelorr
reviewed
Jan 29, 2025
michaelorr
reviewed
Jan 29, 2025
michaelorr
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good. I saw one thing that I think is a typo and one nit about conditional structure. No major red flags on the approach in general. Its a little gross but I guess there's no avoiding a bunch of string interpolation in a library like this.
michaelorr
approved these changes
Jan 29, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: github#1493
Description
MySQL 8.4 deprecates several old-style
master/slave
commands. Unfortunately, we had upgraded our DB to 8.4.3 and then found out after the fact that gh-ost broke, so this PR aims to introduce compatibility across 8.4+.TODO: Update bash scripts used in tests to grep for the correct strings related to master/slave status
script/cibuild
returns with no formatting errors, build errors or unit test errors.I wasn't able to get a minimal mysql 8.4 tarball that would actually pass the CI tests with dbdeployer but did manage to get the docker version running and passing: https://github.com/chen-anders/gh-ost/actions/runs/13026574857
Review Guide
Majority of diffs come from the newly vendored vendor/github.com/hashicorp/go-version library. Actual changes involve building a map of equivalent non-deprecated terms and then subbing the terms in the relevant places where needed.