Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: breakdown of benchmarks #12433

Merged
merged 1 commit into from
Nov 14, 2024
Merged

chore: breakdown of benchmarks #12433

merged 1 commit into from
Nov 14, 2024

Conversation

ematipico
Copy link
Member

Changes

This PR adds 6 benchmarks to CodSpeed. It moves the building of the project to before running the benchmarks, it creates two apps, one with streaming enabled and one where it's not enabled.

The pet project that we create has three routes: /astro, /md and /mdx, so we already know in advance what we want to test.

Testing

This CI should work and we should see the results already.

CodSpeed will go crazy because we will remove the benchmark we already have, so we must acknowledge the deletion.

Docs

N/A

Copy link

changeset-bot bot commented Nov 14, 2024

⚠️ No Changeset found

Latest commit: fa92356

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #12433 will create unknown performance changes

Comparing chore/better-benchmarks (fa92356) with main (9fc2ab8)

Summary

🆕 6 new benchmarks
⁉️ 1 (👁 1) dropped benchmarks

Benchmarks breakdown

Benchmark main chore/better-benchmarks Change
👁 Rendering 4.7 s N/A N/A
🆕 Rendering: streaming [false], .astro file N/A 1.7 s N/A
🆕 Rendering: streaming [false], .md file N/A 21.2 ms N/A
🆕 Rendering: streaming [false], .mdx file N/A 1.2 s N/A
🆕 Rendering: streaming [true], .astro file N/A 1.8 s N/A
🆕 Rendering: streaming [true], .md file N/A 16.4 ms N/A
🆕 Rendering: streaming [true], .mdx file N/A 1.2 s N/A

@ematipico ematipico merged commit e64ec5f into main Nov 14, 2024
15 checks passed
@ematipico ematipico deleted the chore/better-benchmarks branch November 14, 2024 16:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant