fix(core): double encoding during match of routes #13303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8503aac The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
CodSpeed Performance ReportMerging #13303 will not alter performanceComparing Summary
|
|
@ematipico tests do not pass |
|
@florian-lefebvre I am aware of it, but please review the code |
A double decoding error can't be tested because it creates a URL that can't be visited. I manually tested that the double encoding doesn't happen anymore
ematipico
force-pushed
the
fix/double-decoding
branch
from
538ce52 to
8503aac
Compare
florian-lefebvre
approved these changes
Feb 26, 2025
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #13298
Testing
I ended up testing it locally. A test from the original issue can't be used because it contains characters that don't fit a URL, they throw an error.
Docs
N/A