-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore(deps): update esbuild
and vite
versions
#13323
Conversation
🦋 Changeset detectedLatest commit: 61eecbf The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also update the esbuild
version that astro
depends on since it's currently throwing an npm audit
warning (see GHSA-67mh-4wv8-2f99
, doesn't actually apply to us, but is still an annoying warning for users)
https://github.com/withastro/astro/blob/5b6df02c8802bd963b4a466f2785fe0992ab722a/packages/astro/package.json#L144C1-L144C26
Oh, that's the version I should update... I definitely didn't know that. It explains the issue |
esbuild
esbuild
and vite
versions
68236e9
to
fad3e51
Compare
fad3e51
to
9eeb35c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The esbuild
's in packages
directory are still out of date, aren't they?
They seem to be reverted with this force-push: https://github.com/withastro/astro/compare/fad3e518b6d23fcf8bef6630ebce1512b0d2a06b..9eeb35c43ec74d446389ed8b920d99f7d1f8c178 |
Changes
Closes #13322
This PR updates various packages to use the latest of,
vite
andesbuild
, which are affected by the recent security advisory ofesbuild
Testing
CI should pass
Docs
N/A