Security update esbuild & Astro #11149
Open
+387
−600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for astro-docs-2 processing.
|
delucis
reviewed
Mar 4, 2025
package.json
Outdated
Comment on lines
87
to
89
| }, | ||
| "overrides": { | ||
| "esbuild": "^0.25.0" |
There was a problem hiding this comment.
Thanks for looking into this @debiru! This shouldn‘t be needed though. Can you explain why you added it?
There was a problem hiding this comment.
Oh, sorry, I skipped over the line in the PR comment:
The
overridessection is for thetsmpackage.
Do you think this upgrade is necessary? tsm is only used to execute a few scripts we have in CI, not run esbuild’s dev server, so I suspect it’s likely harmless to leave in place.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
This PR updates esbuild and the packages that depend on esbuild.
Changed to use esbuild 0.25.0
The
overridessection is for thetsmpackage.Related issues & labels (optional)