Fixed title text for collapse/expand sidebar button. #877
Conversation
There was a problem hiding this comment.
Hey @christopher,
Thanks for helping out! It looks like there are a few issues for us to work on with this PR.
- Let's not commit that package-lock.json. we'll handle shrinkwrapping along with releases.
- If you feel reformatting the package.json is worthwhile, let's make it a separate issue from this one.
- I suspect you might be working on Windows? It seems your editor has done quite a bit of reformatting to src/ide.ts. It's actually too large for me to load on mobile, so I can't check what specifically it's changed. Instead, can you temporarily disabled that editor feature or use another editor which won't modify the whole file?
Thanks!
|
Sure thing. Sorry about that, I'm using Emacs on Mac OS X and I've modified it to format according to a tsconfig.json file (among other things. It does VS Code level stuff) but apparently when it can't find it it defaults to that formatting. Also, I'll delete the package-lock.json and remember to do that in the future. Again, I'm not sure why package.json was reformatted, possibly because I did an I tried to contribute a few months ago but was told the runtime wasn't ready and I should come back at another time, so I'm trying to do that now. Are you guys open to someone helping with the Rust runtime (v0.4)? I know Rust pretty well and enjoy using it more than I do TypeScript. |
|
Do you have a formatting convention file or something along those lines for me to hook my editor into? |
Fixes issue #860.