This repository has been archived by the owner on Nov 18, 2017. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches
mentions
to be blocks. This is necessary to be able to position the suggestion portal right next to the mention.The problem with this PR is that getting this to work correctly requires us to override the
line
anddefault
nodes to bespan
s, which is obviously not optimal:tm: as it'll break a bunch of folks editors.I tried using
setInline
/splitInline
/... instead ofsetBlock
/... but for some reason that didn't do anything. Maybe @ianstormtaylor has an idea why this exact change withxInline
rather thanxBlock
doesn't work?/cc @oyeanuj