Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🐛 Chore: Fix Type casting errors #142

Merged
merged 5 commits into from
Jul 7, 2024
Merged

🐛 Chore: Fix Type casting errors #142

merged 5 commits into from
Jul 7, 2024

Conversation

create-issue-branch[bot]
Copy link
Contributor

Original issue description

There is a ton of errors from before the types where being properly inferred across the repo. These need to be fixed to clean up the code-base. Thankfully i already built a data helper for making this easier, and to simplify the process it would help to just move all the DB calls to use this helper! contentHelper.ts

Example of the type errors I'm getting in VSCode
image
image

closes #139

@create-issue-branch create-issue-branch bot added bug Something isn't working chore fix labels Jul 6, 2024
@create-issue-branch create-issue-branch bot changed the title Chore: Fix Type casting errors 🐛 Chore: Fix Type casting errors Jul 6, 2024
@Adammatthiesen Adammatthiesen mentioned this pull request Jul 6, 2024
17 tasks
@Adammatthiesen Adammatthiesen marked this pull request as ready for review July 6, 2024 10:06
@Adammatthiesen Adammatthiesen requested a review from a team July 6, 2024 10:07
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, I just left a small suggestion 😁

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this

@Adammatthiesen
Copy link
Member

!coauthor

Copy link
Contributor

github-actions bot commented Jul 7, 2024

Co-authored-by: Adam Matthiesen <30383579+Adammatthiesen@users.noreply.github.com>
Co-authored-by: Jacob Jenkins <7649031+jdtjenkins@users.noreply.github.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

@Adammatthiesen Adammatthiesen merged commit 9569ec5 into main Jul 7, 2024
1 check passed
@Adammatthiesen Adammatthiesen deleted the issue-0139 branch July 7, 2024 04:22
@create-issue-branch create-issue-branch bot mentioned this pull request Jul 23, 2024
17 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working chore fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: Fix Type casting errors
3 participants