✨ Chore: Migrate from Page POST requests to proper API Endpoints #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![create-issue-branch[bot]](https://avatars.githubusercontent.com/in/36017?s=60&v=4){kind=small}
[skip ci]
create-issue-branch
bot
changed the title
create-issue-branch
bot
changed the title
|
🚂 let's gooo |
dreyfus92
approved these changes
Jul 9, 2024
Fryuni
approved these changes
Jul 10, 2024
Comment on lines
-13
to
+16
|
|
||
There was a problem hiding this comment.
Got a stray space there. Run a linter 💅🏼
jdtjenkins
reviewed
Jul 10, 2024
packages/studioCMS/src/integrations/studioCMSDashboard/middleware/index.ts
Outdated
Show resolved
Hide resolved
packages/studioCMS/src/integrations/studioCMSDashboard/middleware/index.ts
Outdated
Show resolved
Hide resolved
packages/studioCMS/src/integrations/studioCMSDashboard/routes/api/pages/delete.ts
Show resolved
Hide resolved
...tudioCMS/src/integrations/studioCMSDashboard/routes/dashboard/components/PageListTable.astro
Show resolved
Hide resolved
jdtjenkins
approved these changes
Jul 10, 2024
packages/studioCMS/src/integrations/studioCMSDashboard/routes/api/pages/delete.ts
Show resolved
Hide resolved
|
!coauthor |
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
Currently we use Page Post requests within the Astro Frontmatter for handling most of the routes on the dashboard ( Example: Lines 45-112 ) This Issue would convert all of these into their own Astro API Endpoint, allowing more flexibility and customization of the StudioCMS Admin dashboard in the future!
closes #157