Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: upgrade feeds config #108

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Conversation

gabaldon
Copy link
Collaborator

@gabaldon gabaldon commented Dec 2, 2021

No description provided.

@gabaldon gabaldon force-pushed the update-data-feeds-config branch from 50a5fd7 to 98f873e Compare December 2, 2021 11:40
@@ -46,7 +46,8 @@ const resolvers = {
return config[parent.feedFullName]?.deviation || ''
},
heartbeat: async (parent, _args, { config }: Context) => {
return config[parent.feedFullName]?.heartbeat || ''
// Heartbeat plus aproximate time in milliseconds that takes to resolve the witnet dr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add finality to a field in the configuration file?

@gabaldon gabaldon force-pushed the update-data-feeds-config branch from e539a36 to e490c9a Compare December 2, 2021 12:20
Copy link
Member

@Tommytrg Tommytrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabaldon gabaldon merged commit e490c9a into witnet:main Dec 2, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants