Skip to content

fix the bug of implicit declaration of function 'objc_setassociatedob… #86

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix the bug of implicit declaration of function 'objc_setassociatedob… #86

wants to merge 1 commit into from

Conversation

somonus
Copy link

@somonus somonus commented Aug 11, 2016

fix the bug of implicit declaration of function 'objc_setassociatedobject' is invalid in c99

@drorbiran
Copy link
Contributor

Hi, we wanted to update you that we are currently postponing the processing of pull requests.
Please refer to React native controllers evolution, we'll appreciate your feedback.

@PaulBGD
Copy link

PaulBGD commented Aug 13, 2016

Will pull requests that fix big issues such as this one not be pulled for the people who have large codebases depending on this package?

@drorbiran drorbiran self-assigned this Aug 14, 2016
@drorbiran
Copy link
Contributor

All bug fixes and relevant PR will be addressed in react-native-navigation

@aksonov
Copy link

aksonov commented Aug 15, 2016 •
edited
Loading

@PaulBGD I'm going to support all fixes and issues in my fork https://github.com/aksonov/react-native-controllers (i've already pushed several unapplied PRs, including this one), react-native-ios-controllers npm package.

@PaulBGD
Copy link

PaulBGD commented Aug 15, 2016

Thanks @aksonov, I'll check it out.

@DanielZlotin
Copy link
Contributor

@PaulBGD we will integrate major / infra PR's and issues as this one before the migration (so we will have a stable enough ground to work on)

artald added a commit that referenced this pull request Aug 24, 2016
@artald
support RN31:
620b07c 
	- a timing issue with RN now requires us to wait until the bridge finishes loading before we can create the RCTRootViews
	- also added the missing import for objc runtime.

related to issue #85 and PR #86
@artald
Copy link
Contributor

artald commented Aug 24, 2016

Fixed in version 2.1.0

@artald artald closed this Aug 24, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@artald artald

@drorbiran drorbiran

Labels
Implement before migrating React native controllers evolution
Projects
None yet
Milestone
Upgrade to react-native 0.31.0
Development

Successfully merging this pull request may close these issues.
6 participants
@somonus @drorbiran @PaulBGD @aksonov @DanielZlotin @artald