Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Artifacts test should not run on all tests #1038

Closed
LeoNatan opened this issue Nov 12, 2018 · 3 comments
Closed

Artifacts test should not run on all tests #1038

LeoNatan opened this issue Nov 12, 2018 · 3 comments
Assignees
@rotemmiz @noomorph
Labels
type: enhancement ⚡️

Comments

@LeoNatan
Copy link
Contributor

Right now, I added a new test file and it failed CI because an artifact is missing in snapshot.

This is a bad way to check the artifacts. It should be for a specific test that will never change, and so the artifacts and snapshots can be predicted correctly.
LeoNatan added a commit that referenced this issue Nov 12, 2018
@LeoNatan
Disable verifty-artifacts step for now
743469c 
#1038
@noomorph
Copy link
Collaborator

I agree it was a temporary solution that we devised with @rotemmiz , but we never had time to sit and think what's the ideal one... :( I'll try to design something better in some nearest future.

The only thing we should track (if we disable this step) — ban changes to artifacts lifecycle or plugins before we merge in a better solution.

@LeoNatan
Copy link
Contributor Author

Sure, that makes sense. Of course, barring any urgent issues, but they will likely not come if they haven't already.

Thanks

rotemmiz pushed a commit that referenced this issue Nov 14, 2018
@LeoNatan @rotemmiz
iOS: Synchronization over waitForBackground and waitForActive states (#…
4a26ae8 
…1036)

* Synchronize performSelector: API for the RN thread

* Add support for new sync points

* Send “ready” in sync manner

* Added waitForActive and waitForBackground to protocol

* Add external logger capability, so that the test project can log into the same logger as Detox

Useful for debugging

* Add test to ensure app transitions are synchronized

* Add repeat_suite convenience script

* Update AppDelegate.m

* Disable verifty-artifacts step for now

#1038

* Run transitions test only on iOS

* Retrigger build
@noomorph
Copy link
Collaborator

Not relevant, I assume.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 29, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@rotemmiz rotemmiz

@noomorph noomorph

Labels
type: enhancement ⚡️
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rotemmiz @noomorph @LeoNatan