Android Sync: Improve RN-timers idling resource such that it would skip over interval-timers #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4vidi
force-pushed
the
timers-ir-skip-over-interval
branch
from
0500a2d to
9187c01
Compare
|
Seems that stress-timeouts are flaky on Android, I'll check. |
…er interval-timers
d4vidi
force-pushed
the
timers-ir-skip-over-interval
branch
from
9187c01 to
2b5d210
Compare
rotemmiz
changed the title
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Though in 5a179ca we've improved the RN-timers idling resource on Android - making it effective for the 1st time, we didn't take repeating timers (i.e. JS intervals) into account.
This branch introduces an iOS-equivalent solution that simply ignores intervals and takes the nearest non-repeating timer as the one to inspect.