Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

(Android) Make RN .46 the new minimal version (i.e. stop support for 44, .45) #1209

Merged
merged 1 commit into from
Mar 18, 2019
Merged

(Android) Make RN .46 the new minimal version (i.e. stop support for 44, .45) #1209

merged 1 commit into from
Mar 18, 2019

Conversation

d4vidi
Copy link
Collaborator

@d4vidi d4vidi commented Mar 17, 2019 •
edited
Loading

Description:
Fixes #1203. Removes build flavours associated with RN version ranges. Removes additional support in test-app and RN-example app.

@d4vidi d4vidi self-assigned this Mar 17, 2019
@d4vidi d4vidi requested a review from rotemmiz March 17, 2019 15:23
@d4vidi
Copy link
Collaborator Author

d4vidi commented Mar 18, 2019 •
edited
Loading

Temporarily removed test HTML reporting from android-pr and android-master jobs on CI to make build pass, will restore once merged.

@d4vidi d4vidi merged commit e4b9f50 into master Mar 18, 2019
@d4vidi d4vidi deleted the rn46-min-ver branch March 18, 2019 12:46
@d4vidi
Copy link
Collaborator Author

d4vidi commented Mar 18, 2019 •
edited
Loading

HTML reporting restored (2 reports instead of 4) ✅

@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@rotemmiz rotemmiz Awaiting requested review from rotemmiz

Assignees

@d4vidi d4vidi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@d4vidi