Fix keyWindow.rootViewController nullability on iOS #1231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Issue: #1230
Some iOS developer use
[UIApplicaiton sharedApplication].keyWindow.rootViewController
as a convenient way to get a VC instance. Surely, this isn't suggested, but it's widely used anyway.When the app is driven by Detox, this call would return null. It's because DTXTouchVisualizerWindow has a very high windowLevel and doesn't has any ViewController.
This PR fixes this issue by avoid making DTXTouchVisualizerWindow the keyWindow.