Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WIP: Location support #195

Merged
merged 4 commits into from
Aug 6, 2017
Merged

WIP: Location support #195

merged 4 commits into from
Aug 6, 2017

Conversation

yogevbd
Copy link
Contributor

@yogevbd yogevbd commented Jul 12, 2017

No description provided.

@rotemmiz rotemmiz requested a review from silyevsk July 12, 2017 09:14
@rotemmiz
Copy link
Member

@silyevsk , we need to investigate why our idling resource doesn't synchronize the async request for location from the app :

 navigator.geolocation.getCurrentPosition(success.bind(this), error.bind(this));

@silyevsk
Copy link
Contributor

silyevsk commented Aug 6, 2017

navigator.geolocation.getCurrentPosition is an sync function, the expectation in the was checked before there was a return from getCurrentPosition. I've changed the screen/test a bit to wrap it with async/await

@silyevsk silyevsk merged commit b58e8c2 into master Aug 6, 2017
@silyevsk silyevsk deleted the location-support branch August 6, 2017 09:10
@wix wix locked and limited conversation to collaborators Jul 23, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants