Updated Guide.RunningOnCI to include Bitrise instructions #264
Conversation
docs/Guide.RunningOnCI.md
Outdated
| inputs: | ||
| - content: |- | ||
| #!/bin/bash | ||
| npm run start & |
There was a problem hiding this comment.
Why run the packager if you're using the release configuration?
There was a problem hiding this comment.
Good catch. I used to run the debug config earlier but then forgot to remove it once I switched to release builds.
I'll remove this.
docs/Guide.RunningOnCI.md
Outdated
| *Build succeeded*: $BITRISE_GIT_MESSAGE | ||
| *Branch*: $BITRISE_GIT_BRANCH | ||
|
|
||
| Fuck it! Ship it! |
There was a problem hiding this comment.
Hey @Monte9
Thank you so much for your help, I really like the guide in general. I got a few small problems for which I added some comments 👍
docs/Guide.RunningOnCI.md
Outdated
|
|
||
| Bitrise is a popular CI service for automating React Native apps. If you are looking to get started with Bitrise, check out [this](http://blog.bitrise.io/2017/07/25/how-to-set-up-a-react-native-app-on-bitrise.html) guide. | ||
|
|
||
| You can run Detox on Bitrise by adding a `tests` workflow. Here's what the Bitrise **.yml** file looks like for doing so: |
There was a problem hiding this comment.
I would like to remove the tests here, the name doesn't matter and it might lead to confusion
There was a problem hiding this comment.
true. I'll remove tests and add a more general explanation instead.
docs/Guide.RunningOnCI.md
Outdated
| - content: |- | ||
| #!/bin/bash | ||
| detox test --configuration ios.sim.release | ||
| - is_debug: 'yes' |
There was a problem hiding this comment.
Should the debug option really be set here?
There was a problem hiding this comment.
not really @DanielMSchmidt
@rotemmiz is_debug basically allows the step to print debug infos about the working dir, tmp file path, exit code, etc
I had that in there when I was trying to debug it and get it to work. I can disable it now.
docs/Guide.RunningOnCI.md
Outdated
| - _tests_setup | ||
| - _detox_tests | ||
| steps: | ||
| - slack@2.6.2: |
There was a problem hiding this comment.
The slack integration is optional, I would like to see it removed and maybe add a link to the Adding webhooks page instead.
There was a problem hiding this comment.
Def optional. Agreed. I can remove it and make it so it's just bare bones detox config.
|
@DanielMSchmidt I have addressed the comments. Please take another look at it. |
|
Thanks a lot for that! |
I use Detox for testing our React Native app and it's been great so far. When it was time to put it on CI, I struggled a little bit to get it working on Bitrise (as we have been using Bitrise for running unit tests so far).
Hence after spending hours trying to getting Detox to work on Bitrise, I finally figure it out and so I thought I should share the solution so others can benefit from it.
I have update the docs to show how to setup Detox on Bitrise. Hope this helps.
Let me know if I need to make any changes. Thanks.